Update geomet to align with requirements.txt #1236
Conversation
|
@absurdfarce just a small tweak, but needed to update the Homebrew formula for Cassandra's dependencies. |
|
Thanks for the ping @bschoening. I was looking at this some last night but didn't actually get it finished. Looking over this ticket also reminded me that we need to handle the removal of distutils in 3.12. My guess is that PYTHON-1334 (the migration to pyproject.toml) will handle that as a side-effect but if setup.py is around in some capacity after that we need to fix it. I've filed PYTHON-1421 to handle that. |
| @@ -383,7 +386,7 @@ def run_setup(extensions): | |||
| else: | |||
| sys.stderr.write("Bypassing Cython setup requirement\n") | |||
|
|
|||
| dependencies = ['geomet>=0.1,<0.3'] | |||
| dependencies = ['geomet>=1.1'] | |||
There was a problem hiding this comment.
Ouch. This is... pretty egregious. But it's definitely the right operation; we test the driver by installing libs from requirements.txt and then running tests so that's what's known to work well. An install from setup.py definitely should match that.
|
Thanks (once again) @bschoening! That was a nice catch on the disconnect between requirements.txt and setup.py... yuck. |
also fixes some pycodestyle issues